Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Make job_build required to pass #6245

Merged
merged 2 commits into from Nov 21, 2022
Merged

ci: Make job_build required to pass #6245

merged 2 commits into from Nov 21, 2022

Conversation

mydea
Copy link
Member

@mydea mydea commented Nov 21, 2022

Currently, because of the logic of the "required jobs passed" meta-CI-job, we only check direct dependends of this job for success. This means that if the build job fails, and all the jobs following this are skipped because of this, it pretends to be "OK", which it is not:

Screenshot 2022-11-21 at 11 04 30

The solution is to add the build job to needs for the required job.

@mydea mydea added the Dev: CI label Nov 21, 2022
@mydea mydea requested a review from a team November 21, 2022 10:06
@mydea mydea self-assigned this Nov 21, 2022
@mydea mydea requested review from lforst and AbhiPrasad and removed request for a team November 21, 2022 10:06
@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 19.52 KB (added)
@sentry/browser - ES5 CDN Bundle (minified) 60.37 KB (added)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.17 KB (added)
@sentry/browser - ES6 CDN Bundle (minified) 53.72 KB (added)
@sentry/browser - Webpack (gzipped + minified) 19.91 KB (added)
@sentry/browser - Webpack (minified) 65.18 KB (added)
@sentry/react - Webpack (gzipped + minified) 19.94 KB (added)
@sentry/nextjs Client - Webpack (gzipped + minified) 45.89 KB (added)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 26.33 KB (added)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 24.74 KB (added)

@mydea mydea merged commit 2f37d32 into master Nov 21, 2022
@mydea mydea deleted the fn/make-build-required branch November 21, 2022 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants