Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(angular): Add Angular 15 Peer Dependencies #6220

Merged
merged 1 commit into from Nov 17, 2022
Merged

feat(angular): Add Angular 15 Peer Dependencies #6220

merged 1 commit into from Nov 17, 2022

Conversation

Lms24
Copy link
Member

@Lms24 Lms24 commented Nov 17, 2022

This PR adds Angular 15 support by adding 15.x as a peer dependency version for the Angular packages. A quick test suggests that all previous features seem to work as usual. Still have to do some experiments with new NG15 features but for now we can at least add basic support and unblock anyone who wants to update to v15.

ref #6219

@Lms24 Lms24 requested review from mydea and lforst November 17, 2022 08:54
@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 19.51 KB (+0.07% 🔺)
@sentry/browser - ES5 CDN Bundle (minified) 60.36 KB (+0.05% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.17 KB (+0.08% 🔺)
@sentry/browser - ES6 CDN Bundle (minified) 53.71 KB (+0.03% 🔺)
@sentry/browser - Webpack (gzipped + minified) 19.9 KB (+0.04% 🔺)
@sentry/browser - Webpack (minified) 65.12 KB (+0.04% 🔺)
@sentry/react - Webpack (gzipped + minified) 19.93 KB (+0.07% 🔺)
@sentry/nextjs Client - Webpack (gzipped + minified) 45.89 KB (+0.03% 🔺)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 26.33 KB (+0.03% 🔺)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 24.74 KB (+0.05% 🔺)

@Lms24 Lms24 enabled auto-merge (squash) November 17, 2022 09:15
@Lms24 Lms24 changed the title feat(angular): Add Angular 15 support feat(angular): Add Angular 15 Peer Dependencies Nov 17, 2022
@Lms24 Lms24 merged commit 034e07d into master Nov 17, 2022
@Lms24 Lms24 deleted the lms-ng15 branch November 17, 2022 09:16
"@angular/common": "10.x || 11.x || 12.x || 13.x || 14.x",
"@angular/core": "10.x || 11.x || 12.x || 13.x || 14.x",
"@angular/router": "10.x || 11.x || 12.x || 13.x || 14.x",
"@angular/common": "10.x || 11.x || 12.x || 13.x || 14.x || 15.x",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside, maybe it is easier to make this: >= 10 && <= 15? As the list gets longer and longer 😅

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point 😅

@Lms24 Lms24 mentioned this pull request Nov 17, 2022
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants