Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): Include _sdkProcessingMetadata when cloning scope #6218

Merged

Conversation

lobsterkatie
Copy link
Member

When I added the _sdkProcessingMetadata field to Scope, I missed adding it to the clone method. This fixes that.

Addresses the withScope problem mentioned in #6139 (comment). (TL;DR - the stored request upon which the RequestData integration relies was getting lost when withScope was called, which in turn meant that no request data was coming through.)

@github-actions
Copy link
Contributor

github-actions bot commented Nov 17, 2022

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 19.52 KB (+0.09% 🔺)
@sentry/browser - ES5 CDN Bundle (minified) 60.37 KB (+0.07% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.17 KB (+0.1% 🔺)
@sentry/browser - ES6 CDN Bundle (minified) 53.72 KB (+0.05% 🔺)
@sentry/browser - Webpack (gzipped + minified) 19.91 KB (+0.07% 🔺)
@sentry/browser - Webpack (minified) 65.18 KB (+0.12% 🔺)
@sentry/react - Webpack (gzipped + minified) 19.94 KB (+0.12% 🔺)
@sentry/nextjs Client - Webpack (gzipped + minified) 45.89 KB (+0.04% 🔺)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 26.33 KB (+0.06% 🔺)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 24.74 KB (+0.08% 🔺)

@lobsterkatie lobsterkatie self-assigned this Nov 17, 2022
@lobsterkatie lobsterkatie requested review from a team, lforst and Lms24 and removed request for a team November 17, 2022 04:52
@Lms24
Copy link
Member

Lms24 commented Nov 17, 2022

I wonder if this has anything to do with #6201 (see #6201 (comment)). Seems unlikely to me but apparently, _sdkProcessingMetadata can make its way to Sentry 🤔

@lobsterkatie
Copy link
Member Author

I wonder if this has anything to do with #6201 (see #6201 (comment)). Seems unlikely to me but apparently, _sdkProcessingMetadata can make its way to Sentry 🤔

Left a comment there, but no, I don't think this can be related, because this PR fixes the opposite problem (sdkProcessingMetadata not being where we want it rather than it being where we don't want it).

@lobsterkatie lobsterkatie force-pushed the kmclb-include-sdkprocessingmetadata-in-scope-clone branch from ee84e9b to 0e3ed7f Compare November 17, 2022 14:51
@lobsterkatie lobsterkatie merged commit 8fdc401 into master Nov 17, 2022
@lobsterkatie lobsterkatie deleted the kmclb-include-sdkprocessingmetadata-in-scope-clone branch November 17, 2022 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants