Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(otel): Use span.toTraceParent to set sentry-trace in propagator #6174

Merged
merged 2 commits into from Nov 10, 2022

Conversation

sl0thentr0py
Copy link
Member

the trace flag is always set to SAMPLED, so this would not propagate the correct sentry-trace header if sentry sampling drops the transaction.

Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@AbhiPrasad AbhiPrasad enabled auto-merge (squash) November 10, 2022 12:52
@AbhiPrasad AbhiPrasad merged commit b4a4342 into master Nov 10, 2022
@AbhiPrasad AbhiPrasad deleted the neel/fix-propagator-extract branch November 10, 2022 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants