Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(core): Prevent creation of new contexts object on scope #6156

Merged
merged 1 commit into from Nov 8, 2022

Conversation

AbhiPrasad
Copy link
Member

Based on feedback from #6154 (comment)

Remove spread operator usage when setting new context so we mutate the current reference instead of creating a new object. Should reduce bundle size and be slightly more performant.

@AbhiPrasad AbhiPrasad enabled auto-merge (squash) November 8, 2022 14:58
@AbhiPrasad AbhiPrasad changed the title perf(core): Prevent creation of new contexts object perf(core): Prevent creation of new contexts object on scope Nov 8, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 8, 2022

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 19.5 KB (+0.03% 🔺)
@sentry/browser - ES5 CDN Bundle (minified) 60.34 KB (-0.06% 🔽)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.15 KB (+0.01% 🔺)
@sentry/browser - ES6 CDN Bundle (minified) 53.69 KB (-0.03% 🔽)
@sentry/browser - Webpack (gzipped + minified) 19.89 KB (-0.01% 🔽)
@sentry/browser - Webpack (minified) 65.1 KB (-0.04% 🔽)
@sentry/react - Webpack (gzipped + minified) 19.91 KB (-0.01% 🔽)
@sentry/nextjs Client - Webpack (gzipped + minified) 45.88 KB (+0.01% 🔺)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 26.3 KB (+0.02% 🔺)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 24.7 KB (+0.01% 🔺)

@AbhiPrasad AbhiPrasad merged commit d2dd7e6 into master Nov 8, 2022
@AbhiPrasad AbhiPrasad deleted the abhi-scope-new-obj branch November 8, 2022 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants