Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tracing): Allow to set instrumenter on Span & Transaction #6136

Merged
merged 1 commit into from Nov 8, 2022

Conversation

mydea
Copy link
Member

@mydea mydea commented Nov 4, 2022

A span & transaction now have a field instrumenter that can be used to check where a the span/transaction was created.
This defaults to sentry.

In later steps, we can use this information to react internally based on SDK config.

ref #6127

@mydea mydea requested review from AbhiPrasad and a team November 4, 2022 09:23
@mydea mydea self-assigned this Nov 4, 2022
@mydea mydea requested review from lforst and removed request for a team November 4, 2022 09:24
@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2022

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 19.49 KB (0%)
@sentry/browser - ES5 CDN Bundle (minified) 60.35 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.12 KB (+0.01% 🔺)
@sentry/browser - ES6 CDN Bundle (minified) 53.67 KB (0%)
@sentry/browser - Webpack (gzipped + minified) 19.86 KB (0%)
@sentry/browser - Webpack (minified) 65.12 KB (0%)
@sentry/react - Webpack (gzipped + minified) 19.88 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified) 45.81 KB (+0.06% 🔺)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 26.26 KB (+0.09% 🔺)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 24.65 KB (+0.13% 🔺)

@mydea mydea requested review from Lms24 and removed request for lforst November 8, 2022 09:07
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mydea mydea merged commit 351be06 into master Nov 8, 2022
@mydea mydea deleted the fn/otel-span-instrumenter branch November 8, 2022 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants