Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): Add instrumenter option to ClientOptions #6128

Merged
merged 3 commits into from Nov 4, 2022

Conversation

mydea
Copy link
Member

@mydea mydea commented Nov 3, 2022

Add a new option instrumenter to the the client options, which can be sentry or otel and defaults to otel.

Nothing is done with that option yet, this will happen in follow up PRs.

It will only have an effect when being set in the node SDK.

ref #6127

packages/node/src/types.ts Outdated Show resolved Hide resolved
@AbhiPrasad AbhiPrasad changed the title feat(node): Add instrumentor option to Node SDK feat(node): Add instrumenter option to Node SDK Nov 3, 2022
@mydea mydea changed the title feat(node): Add instrumenter option to Node SDK feat(node): Add instrumenter option to ClientOptions Nov 3, 2022
@AbhiPrasad AbhiPrasad changed the title feat(node): Add instrumenter option to ClientOptions feat(core): Add instrumenter option to ClientOptions Nov 3, 2022
@AbhiPrasad AbhiPrasad added this to the OpenTelemetry Support milestone Nov 3, 2022
@mydea mydea merged commit a0564ed into master Nov 4, 2022
@mydea mydea deleted the fn/otel-instrumenter branch November 4, 2022 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants