Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tracing): Add an extra conditional check to web vitals onCLS() #6091

Merged
merged 1 commit into from Oct 31, 2022

Conversation

timfish
Copy link
Collaborator

@timfish timfish commented Oct 31, 2022

It's still not immediately clear what causes #6083 since I've been unable to reproduce this locally however it's been reported by numerous users.

Before the upgrade to web vitals v3, there was an additional check here so this PR adds that back.

Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remember adding this extra check because TypeScript complained - let's release this to unblock users.

@AbhiPrasad AbhiPrasad merged commit 83ce1b8 into getsentry:master Oct 31, 2022
@timfish timfish deleted the fix/onCLS branch November 29, 2022 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants