Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(otel): Parse better op/description from otel span where possible #6084

Merged
merged 1 commit into from Oct 28, 2022
Merged

feat(otel): Parse better op/description from otel span where possible #6084

merged 1 commit into from Oct 28, 2022

Conversation

mydea
Copy link
Member

@mydea mydea commented Oct 28, 2022

Based on https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/7422ce2a06337f68a59b552b8c5a2ac125d6bae5/exporter/sentryexporter/sentry_exporter.go#L306, we now try to parse a better op/description from the otel span data, and update the span accordingly when it ends.

Note that we do not do anything for transactions for now.

Part of #6000

@mydea
feat(otel): Parse better op/description from otel span where possible
466faa3 
Based on https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/7422ce2a06337f68a59b552b8c5a2ac125d6bae5/exporter/sentryexporter/sentry_exporter.go#L306, we now try to parse a better `op`/`description` from the otel span data, and update the span accordingly when it ends.

Note that we do not do anything for transactions for now.
@mydea mydea requested review from AbhiPrasad and a team October 28, 2022 12:49
@mydea mydea self-assigned this Oct 28, 2022
@mydea mydea requested review from lforst and removed request for a team October 28, 2022 12:49
AbhiPrasad
AbhiPrasad approved these changes Oct 28, 2022
View reviewed changes
Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! We can def go back and iterate - but now we probably have everything in place to try to test it on a production app

@mydea mydea mentioned this pull request Oct 28, 2022
Closed
10 tasks
@mydea mydea merged commit f33301f into master Oct 28, 2022
@mydea mydea deleted the fn/otel-name branch October 28, 2022 13:42
@AbhiPrasad AbhiPrasad added this to the OpenTelemetry Support milestone Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbhiPrasad AbhiPrasad AbhiPrasad approved these changes

@lforst lforst Awaiting requested review from lforst lforst was automatically assigned from getsentry/team-web-sdk-frontend

Assignees

@mydea mydea

Labels
Package: otel-node Type: Feature
Projects
None yet
Milestone
OpenTelemetry Support
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mydea @AbhiPrasad