Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(otel): Map otel span data to Sentry transaction/span/context #6082

Merged
merged 4 commits into from Oct 28, 2022
Merged

feat(otel): Map otel span data to Sentry transaction/span/context #6082

merged 4 commits into from Oct 28, 2022

Conversation

mydea
Copy link
Member

@mydea mydea commented Oct 28, 2022

Enhance sentry transactions/spans/context with data from OpenTelemetry spans, when using otel-integration.

Summary:

  • otel attributes, resource for transaction --> sentry context
  • otel attributes, kind for span --> sentry data
  • otel status + data from attributes --> sentry status (for both transactions & spans)

Part of #6000

@mydea mydea requested review from AbhiPrasad and a team October 28, 2022 10:44
@mydea mydea self-assigned this Oct 28, 2022
@mydea mydea requested review from lobsterkatie and removed request for a team October 28, 2022 10:44
AbhiPrasad
AbhiPrasad approved these changes Oct 28, 2022
View reviewed changes
Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Let’s make sure we update the PR title to get the feat(otel) in there as well

@AbhiPrasad AbhiPrasad changed the title Map otel span data to Sentry transaction/span/context feat(otel): Map otel span data to Sentry transaction/span/context Oct 28, 2022
@AbhiPrasad AbhiPrasad mentioned this pull request Oct 28, 2022
Closed
10 tasks
@mydea mydea merged commit b0908d0 into master Oct 28, 2022
@mydea mydea deleted the fn/otel-attributes branch October 28, 2022 11:58
@AbhiPrasad AbhiPrasad added this to the OpenTelemetry Support milestone Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbhiPrasad AbhiPrasad AbhiPrasad approved these changes

@lobsterkatie lobsterkatie Awaiting requested review from lobsterkatie lobsterkatie was automatically assigned from getsentry/team-web-sdk-frontend

Assignees

@mydea mydea

Labels
Feature: Integrations
Projects
None yet
Milestone
OpenTelemetry Support
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mydea @AbhiPrasad