Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade peerDependencies of @sentry/nextjs to next 13 #6046

Closed
iduuck opened this issue Oct 26, 2022 · 4 comments · Fixed by #6042
Closed

Upgrade peerDependencies of @sentry/nextjs to next 13 #6046

iduuck opened this issue Oct 26, 2022 · 4 comments · Fixed by #6042

Comments

@iduuck
Copy link

iduuck commented Oct 26, 2022

Problem Statement

Next 13 is out (yay 🥳) – but @sentry/nextjs isn't ready (as of the peerDependencies).

Solution Brainstorm

Add ^13 to peerDependencies (if valid and all goes good of course).

@osdiab
Copy link

osdiab commented Oct 26, 2022

curious if this will be a difficult change, since @sentry/nextjs seems to internally configure a SentryWebpackPlugin and Next 13 uses Turbopack instead, which still doesn't have a stable plugin API nor migration path from Webpack. guessing this might be a while before it's ready.

@fobos531
Copy link

curious if this will be a difficult change, since @sentry/nextjs seems to internally configure a SentryWebpackPlugin and Next 13 uses Turbopack instead, which still doesn't have a stable plugin API nor migration path from Webpack. guessing this might be a while before it's ready.

To be fair, Turbopack is currently opt-in, so right off the bat there shouldn't be anything breaking in case users explicitly try to use Turbopack.

@iduuck
Copy link
Author

iduuck commented Oct 26, 2022

I think it would be enough to just check for the --turbo flag and raise an error, that we are not able to "hook" into it right now.

@lobsterkatie
Copy link
Member

There is a PR to add it to peer dependencies: #6042, just to unblock people.

You're right that full Next 13 support is a bigger question. Opened #6056 to track it.

As for turbopack, it's true - if users use it it won't break anything, but the SDK also won't be added to the app at build time, so any code referring to it will just no-op. I've added a note to the docs about that here: getsentry/sentry-docs#5694.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants