Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Standardize SDKs on MIT License #5993

Merged
merged 25 commits into from Oct 20, 2022
Merged

chore: Standardize SDKs on MIT License #5993

merged 25 commits into from Oct 20, 2022

Conversation

chadwhitacre
Copy link
Member

@chadwhitacre chadwhitacre commented Oct 19, 2022

MIT is our standard license for SDKs. This PR is part of getsentry/team-ospo#56.

Approved by Legal.

@chadwhitacre
Copy link
Member Author

Hrm, this is gonna take some work actually. We have all of these sub-packages ...

@AbhiPrasad
Copy link
Member

@chadwhitacre need us to take this over for the sub packages?

@chadwhitacre
Copy link
Member Author

@AbhiPrasad That'd be awesome, actually. 🐭

package.json and LICENSE files and whatever else should be updated.

@AbhiPrasad
Copy link
Member

Alright, went through and updated all of the subpackages, and cleaned up all the licenses so they follow the same format (the one specified here: https://github.com/getsentry/sentry-javascript/pull/5993/files#diff-c693279643b8cd5d248172d9c22cb7cf4ed163a3c98c8a3f69c2717edd3eacb7)

@chadwhitacre we good to go?

@AbhiPrasad AbhiPrasad self-requested a review October 20, 2022 10:55
@AbhiPrasad AbhiPrasad changed the title Standardize SDKs on MIT chore: Standardize SDKs on MIT License Oct 20, 2022
Copy link
Member Author

@chadwhitacre chadwhitacre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I talked more with Legal and we should keep the copyright years unchanged for now. In the future it'd be great to have a range [start]-[current] but that should really be automated so it stays up to date, out of scope here.

LICENSE Outdated Show resolved Hide resolved
packages/angular/LICENSE Outdated Show resolved Hide resolved
packages/browser/LICENSE Outdated Show resolved Hide resolved
packages/core/LICENSE Outdated Show resolved Hide resolved
packages/ember/LICENSE Outdated Show resolved Hide resolved
packages/types/LICENSE Outdated Show resolved Hide resolved
packages/typescript/LICENSE Outdated Show resolved Hide resolved
packages/utils/LICENSE Outdated Show resolved Hide resolved
packages/vue/LICENSE Outdated Show resolved Hide resolved
packages/wasm/LICENSE Outdated Show resolved Hide resolved
LICENSE Outdated Show resolved Hide resolved
@AbhiPrasad
Copy link
Member

GHA that automatically updates every license file in a repo? 👀

With this, are we good to go? I can slam the ✅ and merge then.

@chadwhitacre
Copy link
Member Author

GHA that automatically updates every license file in a repo? 👀

Something like that.

With this, are we good to go? I can slam the ✅ and merge then.

I'm good. 👍 Thanks @AbhiPrasad! 🥔

@chadwhitacre chadwhitacre enabled auto-merge (squash) October 20, 2022 12:24
Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high-five-cute-dog

@chadwhitacre chadwhitacre merged commit 284184e into master Oct 20, 2022
@chadwhitacre chadwhitacre deleted the cwlw/mit-license branch October 20, 2022 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants