fix(vue): Start pageload transaction earlier to capture missing spans #5983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
AbhiPrasad
approved these changes
Oct 18, 2022
This was referenced Oct 25, 2022
Lms24
added a commit
that referenced
this pull request
Oct 27, 2022
…ctions (#6060) As brought to our attention in #6048, our pageload transaction start change (which makes the transaction start earlier) introduced in #5983 caused custom transaction names to be overwritten when `beforeNavigate` is used to update the transaction name. This patch fixes this problem by checking for the transaction source before (not) updating the current transaction name with the resolved route name once the router's `beforeEach` hook was called. Furthermore, it adds a test to cover this case. See #6048 (comment) for the motivation for creating this PR.
Closed
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the
pageloadtransaction start a little earlier in the Vue routing instrumentation, allowing our SDK to add the rootui.vue.renderspan and a few missed child component spans to the now available and active transaction.Previously, in our Vue routing instrumentation, the
pageloadtransaction would only be created when thebeforeEachhook of the Vue router was called for the first time. This worked reasonably well in Vue 2 apps where this hook was called before any components were rendered. However, in Vue 3 (Vue router v3 and v4) it seems like the routing/rendering process was changed so that the root component would be rendered before the initialbeforeEachrouter hook call.To be clear, this change makes the
pageloadtransaction always start with aurltransaction source (because we don't yet have a matched route at this stage). However, it is updated to a more high-quality source later on - exactly at the time where we previously used to start the transaction. IMO this is fine because by now we've realized that the timing problem of transaction names in DSC propagation requires more fundamental changes. Furthermore, this increases the quality of the pageload transaction, as it is now showing a more representative starting time. This matches the behaviour of other routing instrumentations, such as Angular or Express.fixes #5910