Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(node): Make RequestData integration default #5980

Merged
merged 2 commits into from Oct 19, 2022

Conversation

lobsterkatie
Copy link
Member

@lobsterkatie lobsterkatie commented Oct 17, 2022

This adds the new RequestData integration to the node SDK's default integrations, in order to be able to use it in SDKs besides just nextjs. (It therefore also removes it from the nextjs SDK's specific defaults.) In cases where we haven't yet set up our request handlers to use the integration, the event processor it adds will no-op because it won't find a request object in sdkProcessingMetadata.

Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

h: is there a tracking issue for this? Can we always make sure we have one for stuff like this? I only say this because we have to make docs changes for this, and it would be good to track that as well.

@lobsterkatie lobsterkatie merged commit b34a37b into master Oct 19, 2022
@lobsterkatie lobsterkatie deleted the kmclb-node-make-RequestData-integration-default branch October 19, 2022 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants