Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(remix): Add yargs dependency for uploading sourcemaps #5926

Merged
merged 1 commit into from Oct 11, 2022
Merged

fix(remix): Add yargs dependency for uploading sourcemaps #5926

merged 1 commit into from Oct 11, 2022

Conversation

AbhiPrasad
Copy link
Member

Fixes #5924

Add yargs dep to remix that is used by our upload sourcemaps script:

sentry-javascript/packages/remix/scripts/sentry-upload-sourcemaps.js

Line 2 in 56868e8

const yargs = require('yargs');

@AbhiPrasad AbhiPrasad requested a review from a team October 11, 2022 11:37
@AbhiPrasad AbhiPrasad self-assigned this Oct 11, 2022
@AbhiPrasad AbhiPrasad requested review from lforst and lobsterkatie and removed request for a team October 11, 2022 11:37
@AbhiPrasad AbhiPrasad mentioned this pull request Oct 11, 2022
Closed
3 tasks
@AbhiPrasad AbhiPrasad enabled auto-merge (squash) October 11, 2022 11:39
@AbhiPrasad AbhiPrasad merged commit 9056516 into master Oct 11, 2022
@AbhiPrasad AbhiPrasad deleted the abhi-yargs-remix branch October 11, 2022 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lforst lforst lforst approved these changes

@lobsterkatie lobsterkatie Awaiting requested review from lobsterkatie lobsterkatie was automatically assigned from getsentry/team-web-sdk-frontend

Assignees

@AbhiPrasad AbhiPrasad

Labels
Package: remix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sentry-upload-sourcemaps throwing module not found error
2 participants
@AbhiPrasad @lforst