New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(utils): accept DSN URLs with empty password #5902
Conversation
Thanks for opening a PR! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for opening up this PR. I have a suggestion (see below) but another pair of eyes on this probably won't hurt
Co-authored-by: Lukas Stracke <lukas.stracke@sentry.io>
Seems like prettier isn't yet happy. @JonasKruckenberg, would you mind running |
So I would hahaha, but I actually cannot install the dependencies on my machine the error is this
seems like puppeteer is not supported on m1 Macs? |
Oh wait, do I have to install chrome myself? |
@JonasKruckenberg I can try pushing to this branch if that is ok to you? Also 🤔 not sure why there's an issue here - I can install just fine on my m1. Let me dig in! |
Sure thing! I also don't know why, but maybe it's because I have no chromium browser installed for puppeteer to fall back on? |
Before submitting a pull request, please take a look at our
Contributing guidelines and verify:
yarn lint
) & (yarn test
).