fix(ember): align span operations to new operations #5883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
outsideris
commented
Oct 4, 2022
| 'ember.route.setupController | slow-loading-route', | ||
| 'ember.route.setupController | slow-loading-route.index', | ||
| 'ui.ember.route.setup_controller | slow-loading-route', | ||
| 'ui.ember.route.setup_controller | slow-loading-route.index', | ||
| 'ui.ember.runloop.routerTransitions | undefined', | ||
| 'ui.ember.component.render | component:link-to', | ||
| 'ui.ember.component.render | component:link-to', |
There was a problem hiding this comment.
Should I change ember.route.model operation in this file?
There was a problem hiding this comment.
Yes we should change that to prepend ui
|
Hey @outsideris thanks for opening a PR! Could you split this up so that you create a PR for each package (one PR for ember, one PR for serverless, etc.)? I know that’s a little more work, but it’ll make it easier to review changes (plus it’ll be more contributions for you 😄) |
|
Sure, I will split them. |
outsideris
changed the title
|
I updated this PR for only |
Signed-off-by: Outsider <outsideris@gmail.com>
AbhiPrasad
approved these changes
Oct 6, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #5837
As the description, I changed span operations to new operations. Is it right?
My local development environment is not the same as CI environments, so I will fix some broken lint or tests after I can see CI results.