Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support BrowserTracing with React Router v6.4 #5872

Closed
vietthanhbk1994 opened this issue Oct 3, 2022 · 4 comments · Fixed by #6172
Closed

Support BrowserTracing with React Router v6.4 #5872

vietthanhbk1994 opened this issue Oct 3, 2022 · 4 comments · Fixed by #6172

Comments

@vietthanhbk1994
Copy link

Problem Statement

Whether Sentry supports createBrowserRouter, createMemoryRouter, createHashRouter

Solution Brainstorm

Hopefully Sentry will support createBrowserRouter

@vietthanhbk1994 vietthanhbk1994 changed the title Support React Router v6.4 Support BrowserTracing with React Router v6.4 Oct 3, 2022
@AbhiPrasad
Copy link
Member

Hey, thanks for writing in. We should def support this, backlogging but PRs are welcome!

@VitalyKrenel
Copy link

VitalyKrenel commented Nov 11, 2022

Hey @AbhiPrasad! I was trying to setup Sentry with react-router and after spending ~40 minutes before finding this issue, I would ask for adding a clause that "createBrowserRouter [and other router creators] cannot be used with Sentry right now".

Thing is that docs mentions cases with Routes component and with useRoutes hook in the following sections and I by default assumed that the first is the most generic solution for other cases — which happened to be false 🙂

@trogers1
Copy link

This is necessary for my project's continued paid use of Sentry within my company. Any news on when createBrowserRouter will be supported?

@AbhiPrasad
Copy link
Member

We are actively working on this right now - see #6172

Appreciate your patience while we test this out and write documentation for this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants