fix(node): Only set DeviceContext.boot_time
if os.uptime()
is valid
#5859
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating the
DeviceContext
in the Node SDKContext
integration, we calculate the boot time based onos.uptime
. However, as reported in #5856,os.uptime
might not always be available or return undefined (I couldn't figure out which of the two cases actually was responsible).This PR quickly fixes this bug by simply not setting the boot time in case we don't get a valid up time. It also adds two basic tests for this behaviour. I opted to not set the boot time instead of e.g. defaulting to
0
for uptime because IMO this creates a false boot time that probably causes more confusion than not having it. However, as my context on the Context integration (馃憖) is limited, I'm interested in other opinions on this. cc @timfishfixes #5856