Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question/Bug] _reportAllChanges is not applied in CLS #5621

Closed
3 tasks done
akbarnafisa opened this issue Aug 22, 2022 · 3 comments
Closed
3 tasks done

[Question/Bug] _reportAllChanges is not applied in CLS #5621

akbarnafisa opened this issue Aug 22, 2022 · 3 comments

Comments

@akbarnafisa
Copy link

Is there an existing issue for this?

How do you use Sentry?

Sentry Saas (sentry.io)

Which package are you using?

@sentry/vue

SDK Version

7.9.0

Framework Version

Vue 2.6.0

Link to Sentry event

No response

Steps to Reproduce

  1. Set configuration with _reportAllChanges
new BrowserTracing({
  idleTimeout: 3000,
  _metricOptions: {
    _reportAllChanges: false,
  },
})
  1. enable debug mode
  2. open the web page and see pageload transaction

After doing quick search, the reportAllChanges is not used for CLS, only for LCP, is there any reason behind this?
image

Expected Result

CLS score should be measured

Actual Result

CLS score is not measured

@Lms24
Copy link
Member

Lms24 commented Aug 29, 2022

Hi @akbarnafisa thanks for writing in. Apologies for the late reply!

That's interesting, because getCLS does have reportAllChanges as an optional param in its signature but the variable isn't passed in the call. Might be an oversight but it might also be intentional.

Since my context on web vitals is limited: @AbhiPrasad do you have more details on this?

@Lms24 Lms24 removed their assignment Aug 29, 2022
@AbhiPrasad
Copy link
Member

reportAllChanges only affecting LCP is intentional, since we put that option to help increase LCP count on transactions. I think we can re-evaluate this, but let's do it when we upgrade to web-vitals v3 #5462

@AbhiPrasad
Copy link
Member

As with https://github.com/getsentry/sentry-javascript/releases/tag/7.42.0 we've made sure to report CLS when possible on transaction finish, so closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants