fix(node): Handle colons in stack trace paths

[timfish]

Closes #5151

So the regex doesn't just keep growing in complexity, this change drops the ability to parse stack frames that don't have column numbers. It's my understanding that modern versions of v8/node always have column numbers and this was left over for legacy support.

[AbhiPrasad]

this change drops the ability to parse stack frames that don't have column numbers

Will this break in Node 8? Any way we can validate that?

Rest of the changes look great! Thanks for taking a look Tim!

[timfish]

Will this break in Node 8? Any way we can validate that?

It looks like there were column numbers in stack lines as far back as Node v4 and probably even earlier, I just haven't looked back any further!

My only minor lingering concern is that there are specific cases where column numbers are not included. This seems highly unlikely!

[lobsterkatie]

It sounds like a relatively safe change, given your research. I'm curious, though, what happens when stacktrace parsing fails?

[timfish]

what happens when stacktrace parsing fails?

The lines are all considered independently. If it can't parse any lines you'll get zero frames for the stack trace.

Are you thinking about this?

[AbhiPrasad]

this change drops the ability to parse stack frames that don't have column numbers

Maybe we drop this for now and do it in v8 instead? We can just open a GH issue with the git diff and apply the patch when we start working on the major.

I think the concern is with the possibility of events with empty stacktraces.

We are tracking the major work in this issue - #5194

[AbhiPrasad]

Actually scratch that - let's just do this, I'm confident that it'll be safe, and we can always revert if we need to.