fix(node): Correctly handle Windows paths when resolving module name #5476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timfish
force-pushed
the
fix/windows-module-name
branch
from
2585eb6
to
082d66f
Compare
AbhiPrasad
reviewed
Jul 27, 2022
Possibly, let me try. Looks like I'll need to overwrite |
AbhiPrasad
reviewed
Jul 27, 2022
packages/node/test/module.test.ts
Outdated
|
|
||
| describe('getModule', () => { | ||
| test('Windows', async () => { | ||
| (require.main as any) = { filename: 'C:\\Users\\Tim\\app.js' }; |
There was a problem hiding this comment.
can we mock this return value with jest, and mockRestore afterwards?
There was a problem hiding this comment.
jest.spyOn complains that require and require.main are "not declared configurable". I guess this means the properties are marked as configurable: false and there is no way to modify them other than by overwriting them?
|
I've had a better go and restore |
AbhiPrasad
reviewed
Jul 27, 2022
AbhiPrasad
approved these changes
Jul 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was causing getsentry/sentry-electron#503
It looks like this was never handled correctly and we don't CI test on Windows so this was never noticed!