ref(nextjs): Extract isBuild into an exported function
#5444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lms24
approved these changes
Jul 22, 2022
Lms24
reviewed
Jul 22, 2022
lobsterkatie
force-pushed
the
kmclb-nextjs-add-isBuild-function
branch
from
ff2a4ee
to
3c31f5b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In nextjs hooks which run both during build- and runtime (like
getStaticProps, which mostly is a build-time function, but will run at runtime if revalidation is turned on) it's sometimes helpful to know which you're in, and there's no official way to do that that I've been able to find. In our case, we need to know which phase we're in because by the time pages get loaded in order to be rendered during build, they already have aSentry.init()call baked in, causing the SDK to run. Since certain operations can only happen at runtime, we have logic inindex.server.tsto detect the current phase.This pulls that logic into a utility function, so that it can be exported. (Ultimately this is a selfish change, as I'd like to be able to use
isBuildin my test apps, but I figure it's a harmless addition which might help other developers, too.)