fix(nextjs): Stop sending transactions for requests that 404 #4095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report
|
AbhiPrasad
reviewed
Oct 27, 2021
lobsterkatie
force-pushed
the
kmclb-nextjs-stop-sending-404-transactions
branch
from
e32171b
to
b2872a8
Compare
AbhiPrasad
approved these changes
Oct 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... because they are noisy and in 99.9% of cases* provide no value to the user.
*The only situation in which I could see wanting to have these transactions is if there's some complicated custom logic for what to display on the 404 page, but that feels very unlikely, so I'm comfortable having this be a known limitation.