Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(browser): Make sure that document.head or document.body exists for injectReportDialog #3972

Merged
merged 1 commit into from Sep 10, 2021
Merged

fix(browser): Make sure that document.head or document.body exists for injectReportDialog #3972

merged 1 commit into from Sep 10, 2021

Conversation

kamilogorek
Copy link
Contributor

We had a report of this exact code failing, so better safe than sorry.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 10, 2021 •
edited

size-limit report

Path Size
@sentry/browser - CDN Bundle (gzipped) 21.66 KB (+0.02% 🔺)
@sentry/browser - Webpack 22.67 KB (+0.01% 🔺)
@sentry/react - Webpack 22.71 KB (+0.01% 🔺)
@sentry/browser + @sentry/tracing - CDN Bundle (gzipped) 29.09 KB (0%)

@kamilogorek kamilogorek enabled auto-merge (squash) September 10, 2021 10:20
AbhiPrasad
AbhiPrasad approved these changes Sep 10, 2021
View reviewed changes
Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lol how can this even be undefined?

@kamilogorek kamilogorek merged commit 6b21d76 into master Sep 10, 2021
@kamilogorek kamilogorek deleted the injectReportDialog-guard branch September 10, 2021 11:52
@kamilogorek
Copy link
Contributor Author

I wish i know

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbhiPrasad AbhiPrasad AbhiPrasad approved these changes

@lobsterkatie lobsterkatie Awaiting requested review from lobsterkatie

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kamilogorek @AbhiPrasad