Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref(browser): Migrate unit tests from Chai and Karma to Jest #3965

Merged
merged 1 commit into from Sep 9, 2021
Merged

ref(browser): Migrate unit tests from Chai and Karma to Jest #3965

merged 1 commit into from Sep 9, 2021

Conversation

kamilogorek
Copy link
Contributor

Port of all unit tests in the Browser SDK from Chai+Karma+Sinon to Jest.
No tests were altered, added or remove during the process.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 9, 2021

size-limit report

Path Size
@sentry/browser - CDN Bundle (gzipped) 21.65 KB (0%)
@sentry/browser - Webpack 22.66 KB (0%)
@sentry/react - Webpack 22.7 KB (0%)
@sentry/browser + @sentry/tracing - CDN Bundle (gzipped) 29.08 KB (+0.01% 🔺)

AbhiPrasad
AbhiPrasad approved these changes Sep 9, 2021
View reviewed changes
Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good change (esp getting rid of all the async () that didn't use await).

@kamilogorek kamilogorek merged commit 3f74f82 into master Sep 9, 2021
@kamilogorek kamilogorek deleted the karma-to-jest branch September 9, 2021 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbhiPrasad AbhiPrasad AbhiPrasad approved these changes

@lobsterkatie lobsterkatie Awaiting requested review from lobsterkatie

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kamilogorek @AbhiPrasad