Ember Source - Dev Dependency Only

[nicksteffens]

Why

While doing some dependency upgrades it was discovered ember-source was hard linked to a version behind our own application(s). We needed to have a resolution to adjust this requirement.

What

This adjustment allows all ember versions ^3.24.3 allowing newer versions of ember-source pre-4.0.

[AbhiPrasad]

Thanks for your contribution! Do you think we should add ember-source as a peer dep similar to what we do with our react sdk? https://github.com/getsentry/sentry-javascript/blob/master/packages/react/package.json#L27

[alexlafroscia]

Hey! I'm working with @nicksteffens on this issue and figured I could weigh in

Do you think we should add ember-source as a peer dep similar to what we do with our react sdk?

Totally not a wrong thing to do, but most Ember addon's don't do this. It's "standard" for an Ember addon to only include ember-source as a development dependency. That's the way that a new Ember addon is generated!

https://github.com/ember-cli/ember-addon-output/blob/b5112bf6048763d8bc768363dd15bb33856f6d62/package.json#L53

[k-fish]

Yep they're right that shouldn't be there, got pulled in when I did the 4.0 compat PR, will put a PR to remove it (nvm will just make changes to this branch), thanks 👏 .