fix(nextjs): Include nextjs config's basePath on urlPrefix #3922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @jemmyphan. Thanks for the contribution! This generally looks good, but reviewing it pointed out to me a few places where I think the existing test code didn't work well. So sit tight - I'm going to push those changes through, and then you can rebase this on top of that. I'll keep you posted. |
lobsterkatie
added a commit
that referenced
this pull request
Aug 31, 2021
In the process of reviewing #3922, I realized that there was some cleanup work I could do to make that PR work better. Specifically: - `withSentryConfig` had an incorrect type for one of the arguments to the `userNextConfig` function. - The mock for that same argument was missing its outer layer, and therefore wasn't really what it said it was. - In real life, the `config` property of `buildContext` is equal to the combination of next's default config and the user-provided config. The mock wasn't reflecting this. - That PR was having to compensate for the fact that the mocks for build context were static rather than dynamic, even though those test cases especially illustrate the ways in which the value of the mock needs to change depending on other values in the test. Where necessary, the build context is now calculated as part of the test.
lobsterkatie
reviewed
Sep 1, 2021
There was a problem hiding this comment.
Okay! I made your tests match my changes when I was doing them, just to make sure everything worked, so I've included that, along with some other small updates, as suggestions below. If you commit those, pull, rebase onto current master, and then force push, I think we should end up where we want to be!
jemmyphan
force-pushed
the
fix/nextjs-basepath
branch
from
71bc1e2
to
fa8e735
Compare
|
thanks for the review @lobsterkatie, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
SentryWebpackPluginas part of the nextjs SDK, uploaded sourcemap names point to the wrong path if the nextjsbasePathsetting is used. This makes it so that theurlPrefixvalue includesbasePath, if set.