Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(perf): Add experimental option to improve LCP collection #3879

Merged
merged 6 commits into from Sep 14, 2021

Conversation

k-fish
Copy link
Member

@k-fish k-fish commented Aug 6, 2021

Summary

This will add an experimental option (options._metricOptions._reportAllChanges) that will set 'getLCP' to always report. Now that we are recording LCP element, it should be sufficient to collection the additional information and let the user pick the appropriate LCP element in the ui to improve accuracy dynamically instead. We'd like to test this out on Sentry first.

We can probably cut this as a beta to try it out first.

Refs VIS-1199

@github-actions
Copy link
Contributor

github-actions bot commented Aug 6, 2021

size-limit report

Path Size
@sentry/browser - CDN Bundle (gzipped) 21.66 KB (0%)
@sentry/browser - Webpack 22.67 KB (0%)
@sentry/react - Webpack 22.71 KB (0%)
@sentry/browser + @sentry/tracing - CDN Bundle (gzipped) 29.11 KB (+0.06% 🔺)

@AbhiPrasad AbhiPrasad mentioned this pull request Aug 17, 2021
@AbhiPrasad AbhiPrasad self-assigned this Aug 17, 2021
@AbhiPrasad AbhiPrasad force-pushed the feat/perf-add-private-option-test-intermediate-lcp branch 5 times, most recently from 0c62564 to 9222902 Compare August 23, 2021 20:00
@AbhiPrasad AbhiPrasad mentioned this pull request Aug 23, 2021
@AbhiPrasad AbhiPrasad force-pushed the feat/perf-add-private-option-test-intermediate-lcp branch from 9222902 to fae9e68 Compare August 26, 2021 15:28
@AbhiPrasad AbhiPrasad mentioned this pull request Aug 26, 2021
k-fish and others added 5 commits September 10, 2021 09:28
This will add an experimental option (options._metricOptions._reportAllChanges) that will set 'getLCP' to always report. Now that we are recording LCP element, it should be sufficient to collection the additional information and let the user pick the appropriate LCP element in the ui to improve accuracy dynamically instead. We'd like to test this out on Sentry first.
@AbhiPrasad AbhiPrasad force-pushed the feat/perf-add-private-option-test-intermediate-lcp branch from fae9e68 to 99bd218 Compare September 10, 2021 13:30
@AbhiPrasad
Copy link
Member

AbhiPrasad commented Sep 14, 2021

Shipping this under an option for now, we can remove the option at a later time.

To use this, enable the option in SDK init:

Sentry.init({
  integrations: [
    // other options
    new Integrations.BrowserTracing({
      _metricOptions: {
        _reportAllChanges: true,
      },
    });
  ],
});

@AbhiPrasad AbhiPrasad merged commit a91fb10 into master Sep 14, 2021
@AbhiPrasad AbhiPrasad deleted the feat/perf-add-private-option-test-intermediate-lcp branch September 14, 2021 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants