New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(perf): Add experimental option to improve LCP collection #3879
Merged
AbhiPrasad
merged 6 commits into
master
from
feat/perf-add-private-option-test-intermediate-lcp
Sep 14, 2021
Merged
feat(perf): Add experimental option to improve LCP collection #3879
AbhiPrasad
merged 6 commits into
master
from
feat/perf-add-private-option-test-intermediate-lcp
Sep 14, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report
|
Closed
AbhiPrasad
force-pushed
the
feat/perf-add-private-option-test-intermediate-lcp
branch
5 times, most recently
from
August 23, 2021 20:00
0c62564
to
9222902
Compare
Closed
AbhiPrasad
force-pushed
the
feat/perf-add-private-option-test-intermediate-lcp
branch
from
August 26, 2021 15:28
9222902
to
fae9e68
Compare
Closed
This will add an experimental option (options._metricOptions._reportAllChanges) that will set 'getLCP' to always report. Now that we are recording LCP element, it should be sufficient to collection the additional information and let the user pick the appropriate LCP element in the ui to improve accuracy dynamically instead. We'd like to test this out on Sentry first.
AbhiPrasad
force-pushed
the
feat/perf-add-private-option-test-intermediate-lcp
branch
from
September 10, 2021 13:30
fae9e68
to
99bd218
Compare
Shipping this under an option for now, we can remove the option at a later time. To use this, enable the option in SDK init: Sentry.init({
integrations: [
// other options
new Integrations.BrowserTracing({
_metricOptions: {
_reportAllChanges: true,
},
});
],
}); |
kamilogorek
approved these changes
Sep 14, 2021
AbhiPrasad
deleted the
feat/perf-add-private-option-test-intermediate-lcp
branch
September 14, 2021 13:48
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This will add an experimental option (options._metricOptions._reportAllChanges) that will set 'getLCP' to always report. Now that we are recording LCP element, it should be sufficient to collection the additional information and let the user pick the appropriate LCP element in the ui to improve accuracy dynamically instead. We'd like to test this out on Sentry first.
We can probably cut this as a beta to try it out first.
Refs VIS-1199