Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular error handler should report handled: false #3836

Closed
bruno-garcia opened this issue Jul 26, 2021 · 3 comments · Fixed by #3844
Closed

Angular error handler should report handled: false #3836

bruno-garcia opened this issue Jul 26, 2021 · 3 comments · Fixed by #3844

Comments

@bruno-garcia
Copy link
Member

bruno-garcia commented Jul 26, 2021

Currently the Angular error handler integration executes a normal captureException:

const eventId = runOutsideAngular(() => Sentry.captureException(extractedError));

This results in a handled error in Sentry:

image

Mechanism ideally would be angular or something that helps differentiate where it comes from.
Example event in sentry

@bruno-garcia
Copy link
Member Author

bruno-garcia commented Jul 11, 2022

@vladanpaunovic @smeubank there's a PR open for a year that addresses this (#3844), can we get it merged please? 🙏

I see prio is low. To be fair this affects Release Health, prioritization (since unhandled errors have higher priority) and the label on the produdct. I'd argue this is high priority as it's Sentry's main product: error reporting

@lobsterkatie
Copy link
Member

lobsterkatie commented Jul 12, 2022

Related: #5375 and #5408

@vladanpaunovic
Copy link
Contributor

Thanks @bruno-garcia, @onurtemizkan rebased the PR and @Lms24 will review it. Looking forward to bring this in soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants