-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Update span op for outgoing HTTP requests #3821
Conversation
We've established that incoming requests have op=http.server and outgoing requests have op=http.client. Specification available at: https://develop.sentry.dev/sdk/features/#http-client-integrations Last update: getsentry/develop#341
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will have product ramifications. Pinging @getsentry/visibility to get their thoughts.
size-limit report
|
Nice, our tests caught something :D |
Haha, yeah, it was a |
Do you mean operations breakdown? Ops breakdown uses |
@k-fish @rhcarvalho @AbhiPrasad tldr: this has no product ramifications; this rename will match cleanly on the operation names breakdown feature. In other words, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect, think we are good to go then.
We've established that incoming requests have
op=http.server
and outgoing requests haveop=http.client
.Specification available at: https://develop.sentry.dev/sdk/features/#http-client-integrations
Last update: getsentry/develop#341
Note: this has the unfortunate potential to break anything relying on the old
op
value. While the change is simple, some consideration needs to be taken.