fix(nextjs): Use local copies for all sentry packages when testing on vercel #3812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report
|
HazAT
approved these changes
Jul 16, 2021
kamilogorek
reviewed
Jul 16, 2021
kamilogorek
reviewed
Jul 16, 2021
kamilogorek
suggested changes
Jul 16, 2021
lobsterkatie
force-pushed
the
kmclb-nextjs-use-only-local-sentry-packages-on-vercel
branch
from
990bd22
to
930bf3e
Compare
Good suggestions, thanks! |
lobsterkatie
force-pushed
the
kmclb-nextjs-use-only-local-sentry-packages-on-vercel
branch
from
930bf3e
to
0729817
Compare
kamilogorek
approved these changes
Jul 19, 2021
lobsterkatie
deleted the
kmclb-nextjs-use-only-local-sentry-packages-on-vercel
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when testing a project on vercel against a particular branch of the SDK repo, only the
@sentry/nextjspackage was reflecting the branches changes (by dint of the fact that it was listed as a file dependency pointing to the built SDK). All other@sentry/*packages were still getting downloaded fromnpm.This fixes the install script so that it will force all interdependencies between
@sentry/*packages to be specified by absolute file paths. That way, only the branch versions of all packages will be used.There are also some small logging improvements and some generalized cleanup.