Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(browser): Use scope data in report dialog #3792

Merged
merged 3 commits into from
Jul 12, 2021

Conversation

AbhiPrasad
Copy link
Member

If user is set on the scope, we set that user in report dialog options.
If a user is already set in the report dialog options, it takes
precedence over the user object in the scope.

Fixes #2607

If user is set on the scope, we set that user in report dialog options.
If a user is already set in the report dialog options, it takes
precedence over the user object in the scope.

Fixes #2607
@github-actions
Copy link
Contributor

github-actions bot commented Jul 9, 2021

size-limit report

Path Size
@sentry/browser - CDN Bundle (gzipped) 21.46 KB (+0.01% 🔺)
@sentry/browser - Webpack 22.47 KB (0%)
@sentry/react - Webpack 22.5 KB (0%)
@sentry/browser + @sentry/tracing - CDN Bundle (gzipped) 28.95 KB (+0.01% 🔺)

@kamilogorek kamilogorek merged commit 4425e49 into master Jul 12, 2021
@kamilogorek kamilogorek deleted the abhi-add-user-to-dialog branch July 12, 2021 08:51
@kamilogorek
Copy link
Contributor

Fixed one test and merged to include in the release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User Feedback Dialog doesn't use data from user that is on the scope
2 participants