Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix - Check client function access (_captureRequestSession) #3773

Merged
merged 6 commits into from
Jul 1, 2021
Merged

Bugfix - Check client function access (_captureRequestSession) #3773

merged 6 commits into from
Jul 1, 2021

Conversation

dfcook
Copy link
Contributor

@dfcook dfcook commented Jun 30, 2021

Our Next.js project is seeing 1000's of errors logged in production:

TypeError GET /^(?!/_next|/static).*$/
client._captureRequestSession is not a function

This is due to the server side code being passed a BrowserClient. This might be due to how we have configured the product, however a simple check on the function being present on the client would resolve.

No tests added as trivial change.

  • If you've added code that should be tested, please add tests.
  • Ensure your code lints and the test suite passes (yarn lint) & (yarn test).

@dfcook dfcook requested a review from kamilogorek as a code owner June 30, 2021 13:10
@dfcook dfcook changed the title Bugfix/check client function access Bugfix - Check client function access (_captureRequestSession) Jun 30, 2021
@kamilogorek kamilogorek enabled auto-merge (squash) June 30, 2021 13:17
@kamilogorek kamilogorek enabled auto-merge (squash) June 30, 2021 13:17
auto-merge was automatically disabled June 30, 2021 13:33

Head branch was pushed to by a user without write access

@kamilogorek kamilogorek enabled auto-merge (squash) June 30, 2021 13:40
@dfcook dfcook closed this Jun 30, 2021
auto-merge was automatically disabled June 30, 2021 16:24

Pull request was closed

@dfcook dfcook reopened this Jun 30, 2021
@kamilogorek kamilogorek enabled auto-merge (squash) July 1, 2021 07:42
@kamilogorek kamilogorek merged commit dcdb113 into getsentry:master Jul 1, 2021
@kamilogorek
Copy link
Contributor

Thanks!

@dfcook dfcook deleted the bugfix/check-client-function-access branch July 1, 2021 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants