Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(angular): do not run change detection when finishing transaction #3622

Merged
merged 1 commit into from Jun 4, 2021
Merged

perf(angular): do not run change detection when finishing transaction #3622

merged 1 commit into from Jun 4, 2021

Conversation

arturovt
Copy link
Contributor

Before submitting a pull request, please take a look at our
Contributing guidelines and verify:

  • If you've added code that should be tested, please add tests.
  • Ensure your code lints and the test suite passes (yarn lint) & (yarn test).

There is another perf PR that has the same stuff with isNgZoneEnabled, we can merge some PR first and then I'll move that constant into some file to share it.

@kamilogorek kamilogorek merged commit 6433cd0 into getsentry:master Jun 4, 2021
@arturovt arturovt deleted the perf/angular-finish-transaction branch June 4, 2021 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants