fix: Correctly attach installed integrations to sdkinfo #3447
+25
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamilogorek
requested review from
a team,
rhcarvalho and
iker-barriocanal
and removed request for
a team
Closed
9 tasks
size-limit report
|
iker-barriocanal
approved these changes
Apr 23, 2021
kamilogorek
force-pushed
the
attach-integrations-to-sdkinfo
branch
from
e700e66 to
6b9921c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also changed
SdkInfotype, because we attach different parts of the information at different times, which is reasonable, but that type did not allow that. It's misc information anyway, so we don't need to be that strict here.