Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(ember): Silence deprecation warnings in beta #3346

Merged
merged 4 commits into from Mar 29, 2021

Conversation

k-fish
Copy link
Member

@k-fish k-fish commented Mar 24, 2021

Summary

We can deal with deprecations once they hit mainline, this should hopefully silence deprecations in the scenarios so we can see failures more easily and not spit out too many logs

We can deal with deprecations once they hit mainline, this should hopefully silence deprecations in the scenarios so we can see failures more easily and not spit out too many logs
@github-actions
Copy link
Contributor

github-actions bot commented Mar 24, 2021

size-limit report

Path Size
@sentry/browser - CDN Bundle (gzipped) 20.47 KB (-0.01% 🔽)
@sentry/browser - Webpack 21.32 KB (0%)
@sentry/react - Webpack 21.36 KB (0%)
@sentry/browser + @sentry/tracing - CDN Bundle (gzipped) 27.56 KB (-0.01% 🔽)

…ove silent on try command, update addon with a large amount of deprecations
@kamilogorek
Copy link
Contributor

Looks good although tests are failing.

@kamilogorek
Copy link
Contributor

@k-fish Ping about failing tests so that I can release it.

Copy link
Contributor

@kamilogorek kamilogorek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to merge as long as tests pass (ember tests on master are also broken fwiw)

@k-fish k-fish merged commit 9af3095 into master Mar 29, 2021
@k-fish k-fish deleted the ref/ember-silence-deprecations-in-tests branch March 29, 2021 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants