Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref: Add fast-path to fetchImpl and cleanup redundant iframe #3341

Merged
merged 2 commits into from Mar 22, 2021
Merged

ref: Add fast-path to fetchImpl and cleanup redundant iframe #3341

merged 2 commits into from Mar 22, 2021

Conversation

kamilogorek
Copy link
Contributor

@kamilogorek kamilogorek mentioned this pull request Mar 21, 2021
Merged
@github-actions
Copy link
Contributor

github-actions bot commented Mar 21, 2021 •
edited

size-limit report

Path Size
@sentry/browser - CDN Bundle (gzipped) 20.45 KB (+0.1% 🔺)
@sentry/browser - Webpack 21.29 KB (+0.06% 🔺)
@sentry/react - Webpack 21.33 KB (+0.05% 🔺)
@sentry/browser + @sentry/tracing - CDN Bundle (gzipped) 27.53 KB (+0.06% 🔺)

@kamilogorek kamilogorek mentioned this pull request Mar 22, 2021
Closed
8 tasks
@kamilogorek kamilogorek requested a review from a team March 22, 2021 11:34
@kamilogorek kamilogorek changed the title ref: Add fast-path to fetchImpl ref: Add fast-path to fetchImpl and cleanup redundant header Mar 22, 2021
@kamilogorek kamilogorek changed the title ref: Add fast-path to fetchImpl and cleanup redundant header ref: Add fast-path to fetchImpl and cleanup redundant iframe Mar 22, 2021
lobsterkatie
lobsterkatie approved these changes Mar 22, 2021
View reviewed changes
Copy link
Member

@lobsterkatie lobsterkatie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kamilogorek kamilogorek merged commit 2d6196b into master Mar 22, 2021
@kamilogorek kamilogorek deleted the fetch-impl-fastpath branch March 22, 2021 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lobsterkatie lobsterkatie lobsterkatie approved these changes

@iker-barriocanal iker-barriocanal iker-barriocanal approved these changes

@mitsuhiko mitsuhiko Awaiting requested review from mitsuhiko

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kamilogorek @lobsterkatie @iker-barriocanal