Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(tracing): Clarify naming in BrowserTracing integration #3338

Merged
merged 8 commits into from Mar 22, 2021

Conversation

lobsterkatie
Copy link
Member

Literally nothing but renames, with a few goals:

  1. Bring function naming more in line with what we do elsewhere in the SDK. Specifically, make function names more "verby," so that it's clearer for the reader what's an actor and what's a thing being acted upon.
  2. Disambiguate keys and values. I have been careful not to rename the publicly-available routingInstrumentation integration option anywhere. I have, however, renamed our placeholders for that option's value.
  3. Disambiguate the transaction-starting function passed to the routing instrumentation from its namesake Sentry.startTransaction.
  4. Admittedly this currently only matters to me, but doing this was a way to carefully examine the routing instrumentation code, which is helpful since I'm about to build a version of it for next.js.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 18, 2021

size-limit report

Path Size
@sentry/browser - CDN Bundle (gzipped) 20.45 KB (-0.01% 🔽)
@sentry/browser - Webpack 21.29 KB (0%)
@sentry/react - Webpack 21.33 KB (0%)
@sentry/browser + @sentry/tracing - CDN Bundle (gzipped) 27.53 KB (-0.01% 🔽)

@lobsterkatie lobsterkatie force-pushed the kmclb-clarify-browsertracing-naming branch from 1ccb7c3 to 318ebd0 Compare March 18, 2021 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants