Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fallback to empty string if req.baseUrl is empty #3329

Merged
merged 1 commit into from Mar 22, 2021
Merged

fix: Fallback to empty string if req.baseUrl is empty #3329

merged 1 commit into from Mar 22, 2021

Conversation

kamilogorek
Copy link
Contributor

This comment (and link with the test) provide time and time that it's false. Even today during some of my tests:

image

@github-actions
Copy link
Contributor

size-limit report

Path Size
@sentry/browser - CDN Bundle (gzipped) 20.43 KB (+0.01% 🔺)
@sentry/browser - Webpack 21.28 KB (0%)
@sentry/react - Webpack 21.32 KB (0%)
@sentry/browser + @sentry/tracing - CDN Bundle (gzipped) 27.51 KB (+0.01% 🔺)

lobsterkatie
lobsterkatie approved these changes Mar 22, 2021
View reviewed changes
Copy link
Member

@lobsterkatie lobsterkatie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad. 😕 Thanks for fixing.

@kamilogorek kamilogorek merged commit 77b8301 into master Mar 22, 2021
@kamilogorek kamilogorek deleted the skip-baseurl-if-empty branch March 22, 2021 13:45
@BenjD90
Copy link

BenjD90 commented Mar 26, 2021

Hello @lobsterkatie,

Do you have an idea when this fix will be released ?

Thanks in advance,
Benjamin

@BenjD90
Copy link

BenjD90 commented Mar 26, 2021 •
edited

I'll rollback to v 5.27.6 to avoid this bug.

@kamilogorek
Copy link
Contributor Author

@BenjD90 we'll release a new version Today or Tomorrow at the latest.

@kamilogorek
Copy link
Contributor Author

@BenjD90 released in 6.2.4

@BenjD90
Copy link

BenjD90 commented Mar 30, 2021

thanks 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lobsterkatie lobsterkatie lobsterkatie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kamilogorek @BenjD90 @lobsterkatie