Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add SentryRequestType to RateLimitingCategory mapping #3328

Merged
merged 2 commits into from Mar 23, 2021

Conversation

kamilogorek
Copy link
Contributor

Fixes a limiting of error-based only events.

@kamilogorek kamilogorek requested a review from a team March 16, 2021 10:56
@github-actions
Copy link
Contributor

github-actions bot commented Mar 16, 2021

size-limit report

Path Size
@sentry/browser - CDN Bundle (gzipped) 20.46 KB (+0.15% 🔺)
@sentry/browser - Webpack 21.3 KB (+0.14% 🔺)
@sentry/react - Webpack 21.35 KB (+0.14% 🔺)
@sentry/browser + @sentry/tracing - CDN Bundle (gzipped) 27.54 KB (+0.11% 🔺)

@lobsterkatie
Copy link
Member

Can you give a little more context on what the problem was here? The changes seem fine but it's not clear what problem they fix or exactly how they fix it.

@kamilogorek
Copy link
Contributor Author

Oh, I think the the fix being this small makes it actually hard to see.

In Relay, rate-limiting for error events using type: error, however in all SDKs, the type for such an event is type: event so we need to make sure that we perform event => error => event translations. For session and transaction it's all 1:1

@lobsterkatie
Copy link
Member

lobsterkatie commented Mar 22, 2021

In Relay, rate-limiting for error events using type: error, however in all SDKs, the type for such an event is type: event

Oy.

Okay, yeah, that's helpful, thanks.

@kamilogorek kamilogorek merged commit a6f8dc2 into master Mar 23, 2021
@kamilogorek kamilogorek deleted the map-rate-limits branch March 23, 2021 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants