New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to filter safari extensions #3313
Comments
We are facing the same issue |
Friendly bump. :) |
I have it turned on, yet I still can see the errors like the one above still coming in. |
@senky can you link one of the events that came through? I'll take a look. |
@senky the fix is coming :) |
It's an error I got. TypeError: undefined is not an object (evaluating 'g.toString') |
can we pass in something like |
It should already filter these events correctly through the Sentry itself when you switch browser filtering on in your project settings. |
denyUrls: [/^chrome-extension:///i, /safari-(web-)?extension:/] |
No, you need to do this only: #3313 (comment) |
That setting is already done. However, I received this error. TypeError: undefined is not an object (evaluating 'g.toString') |
We're seeing exactly the same error. The setting "Filter out errors known to be caused by browser extensions" is turned on for the project.
|
I just verified it locally, and the filtering works as expected using the lastest SDK and Sentry SaaS. Please provide a link to the events that should be filtered, but were not. |
Sorry, I should have shared a link already. And thanks for the quick response. I think our SDK is mostly up to date (6.4.1). Here is a link to an event. It happened 6 times on what looks like the same device: https://sentry.io/organizations/bolinda/issues/2415511757/?project=1369486 |
Thanks, that's helpful. Apparently the raw stack looks slightly differently, and SDK was not able to parse it correctly, which makes the Could you use the snippet below to configure your SDK and get back to me once you notice the same issue again? This time it should have additional data attached. Sentry.init({
beforeSend(event, hint) {
try {
if (hint.originalException.message === `undefined is not an object (evaluating 'g.toString')`) {
event.extra = event.extra || {};
event.extra.rawStack = hint.originalException.stack;
}
} catch (e) {
return event;
}
return event;
},
}); |
Yes, will do. I'll get back to you when we see the event again. |
Hi, @kamilogorek. We are seeing a similar error coming from a safari web extension. We are on the latest Sentry SDK and have "Filter out errors known to be caused by browser extensions" enabled. Suggestions? |
@trmpowell please see the comment above #3313 (comment) Although in your case it would be |
@kamilogorek, we just got this one after adding the code snippet you requested: |
@kamilogorek, we just got a couple more if it's helpful: |
Thanks @trmpowell! #3929 should fix it soon. |
@kamilogorek, can you confirm which SDK version this should be fixed in? We are on 6.12.0 and just got another |
Ah, it looks like your PR went in after 6.12.0. We will upgrade. Thanks! |
Package + Version
@sentry/browser
@sentry/node
raven-js
raven-node
(raven for node)Version:
Description
Chrome extensions are easy to filter out:
But when I try it with safari extensions, sentry doesn't filter it out:
I even tried with
ignoreErrors
:but to no avail. That is extremely weird, because I thought
ignoreErrors
checks for match in raw error string, which 100% containssafari-extension:
orsafari-web-extension:
. See example:Am I doing sometihing wrong? Is there a way to filter safari extensions out?
The text was updated successfully, but these errors were encountered: