Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Don't override metadata #3304

Merged
merged 2 commits into from Mar 3, 2021
Merged

fix: Don't override metadata #3304

merged 2 commits into from Mar 3, 2021

Conversation

iker-barriocanal
Copy link
Member

When initializing the React SDK, overriding metadata won't allow other SDKs to use that info. This PR prevents that.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2021

size-limit report

Path Size
@sentry/browser - CDN Bundle (gzipped) 20.28 KB (+0.01% 🔺)
@sentry/browser - Webpack 21.18 KB (0%)
@sentry/react - Webpack 21.22 KB (+0.04% 🔺)
@sentry/browser + @sentry/tracing - CDN Bundle (gzipped) 27.36 KB (0%)

@HazAT HazAT merged commit 9b32eca into master Mar 3, 2021
@HazAT HazAT deleted the fix/react-metadata-override branch March 3, 2021 12:29
ahmedetefy pushed a commit that referenced this pull request Mar 10, 2021
ahmedetefy pushed a commit that referenced this pull request Mar 10, 2021
This was referenced Mar 11, 2021
This was referenced Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants