fix(release health): Only create sessions if the correct methods are defined #3281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report
|
lobsterkatie
force-pushed
the
kmclb-try-catch-start-session
branch
from
805b3c5
to
48b53f5
Compare
kamilogorek
approved these changes
Mar 3, 2021
lobsterkatie
force-pushed
the
kmclb-try-catch-start-session
branch
from
48b53f5
to
99440a3
Compare
ahmedetefy
pushed a commit
that referenced
this pull request
Mar 10, 2021
This was referenced Mar 11, 2021
This was referenced Mar 15, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are edge cases (see #3207 and #3234) where the version of
@sentry/browserloaded on a page can be >= 6.0.0 and the version of@sentry/hubloaded can be < 5.27.0. When this happens, the former callshub.startSession()but the latter doesn't have such a method, and an error is thrown. This protects against that possibility.