fix(node/browser): Set SDK info in client constructor #3279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report
|
ahmedetefy
approved these changes
Mar 1, 2021
ahmedetefy
pushed a commit
that referenced
this pull request
Mar 3, 2021
This was referenced Mar 7, 2021
ahmedetefy
pushed a commit
that referenced
this pull request
Mar 10, 2021
ahmedetefy
pushed a commit
that referenced
this pull request
Mar 10, 2021
This was referenced Mar 10, 2021
This was referenced Mar 15, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #3177, SDK metadata (version, package name, etc) is set in
Sentry.init(). This works great, except when you instantiate a client directly, as we tell people to do here. In that case, the data never gets set.This moves that data-setting into the constructors of
BrowserClientandNodeClient. That way, if anyone creates a client themselves, they get the data. To protect the data that's set in wrapper classes like@sentry/reactand@sentry/serverless(data which continues to be set in.init()), the client constructors only set their data if there isn't already data there.