fix(react): Remove react-dom peer dependency for RN #3250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report
|
|
From what I see, we indeed do not use react-dom directly in the code. 👍 |
kamilogorek
approved these changes
Feb 17, 2021
This was referenced Mar 7, 2021
ahmedetefy
pushed a commit
that referenced
this pull request
Mar 10, 2021
Co-authored-by: Kamil Ogórek <kamil.ogorek@gmail.com>
This was referenced Mar 10, 2021
This was referenced Mar 14, 2021
Closed
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes
react-domas a peer dependency from@sentry/react.react-domis not a dependency on React Native projects and we are adding this unused dependency to our users, or causing unmet peer dependency warnings.getsentry/sentry-react-native#1328
getsentry/sentry-react-native#1065