Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vue): Add vue-router to peer dependencies #3214

Merged
merged 1 commit into from
Feb 1, 2021

Conversation

lobsterkatie
Copy link
Member

We use vue-router in our router instrumentation for Vue. Presumably if you're using our Vue router instrumentation, you already have vue-router installed, but just to dot our I's and cross our T's, let's say out loud that it's necessary.

@github-actions
Copy link
Contributor

size-limit report

Path Size
@sentry/browser - CDN Bundle (gzipped) 20.23 KB (-0.01% 🔽)
@sentry/browser - Webpack 21.1 KB (0%)
@sentry/react - Webpack 21.12 KB (0%)
@sentry/browser + @sentry/tracing - CDN Bundle (gzipped) 27.39 KB (0%)

@kamilogorek kamilogorek merged commit da669ce into master Feb 1, 2021
@kamilogorek kamilogorek deleted the kmclb-vue-router-peer-dependency branch February 1, 2021 15:45
This was referenced Mar 7, 2021
This was referenced Mar 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants