Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: Make ExpressRequest not extend http.IncomingMessage anymore #3211

Merged
merged 1 commit into from
Jan 28, 2021

Conversation

kamilogorek
Copy link
Contributor

@kamilogorek kamilogorek commented Jan 28, 2021

This allows it to be used within Koa app without any modifications.

Fixes #3137

@kamilogorek kamilogorek requested a review from a team January 28, 2021 10:55
@github-actions
Copy link
Contributor

size-limit report

Path Size
@sentry/browser - CDN Bundle (gzipped) 20.23 KB (-0.01% 🔽)
@sentry/browser - Webpack 21.1 KB (0%)
@sentry/react - Webpack 21.12 KB (0%)
@sentry/browser + @sentry/tracing - CDN Bundle (gzipped) 27.39 KB (-0.01% 🔽)

@kamilogorek kamilogorek merged commit 8c20fd2 into master Jan 28, 2021
@kamilogorek kamilogorek deleted the generalize-expressrequest-type branch January 28, 2021 15:04
This was referenced Mar 7, 2021
This was referenced Mar 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unexpected Typing issue for ExpressRequest using Koa
2 participants