Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref: Revert the usage of globalThis for getGlobalObject util #2851

Merged
merged 1 commit into from Aug 27, 2020
Merged

ref: Revert the usage of globalThis for getGlobalObject util #2851

merged 1 commit into from Aug 27, 2020

Conversation

kamilogorek
Copy link
Contributor

It has been introduced in TypeScript 3.4, but some older frameworks are still pinned to the older compilers.

image

@kamilogorek kamilogorek requested a review from HazAT August 27, 2020 09:27
HazAT
HazAT approved these changes Aug 27, 2020
View reviewed changes
Copy link
Member

@HazAT HazAT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

q3V3Xe3-796x531

@kamilogorek kamilogorek merged commit ceb1d1b into master Aug 27, 2020
@kamilogorek kamilogorek deleted the revert-window-type branch August 27, 2020 09:36
@github-actions
Copy link
Contributor

size-limit report

Path Size
@sentry/browser - CDN Bundle (gzipped) 17.68 KB (+0.01% 🔺)
@sentry/browser - Webpack 18.46 KB (0%)
@sentry/react - Webpack 18.46 KB (0%)
@sentry/browser + @sentry/tracing - CDN Bundle (gzipped) 22.77 KB (0%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HazAT HazAT HazAT approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kamilogorek @HazAT