Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Make sure that SyncPromise handler is called only once #2511

Merged
merged 4 commits into from
Mar 25, 2020
Merged

fix: Make sure that SyncPromise handler is called only once #2511

merged 4 commits into from
Mar 25, 2020

Conversation

kamilogorek
Copy link
Contributor

Fixes #2506

@kamilogorek kamilogorek requested a review from HazAT March 23, 2020 13:29
@getsentry-bot
Copy link
Contributor

getsentry-bot commented Mar 23, 2020 •
edited

Warnings
⚠️ Please add a changelog entry for your changes.
Messages
📖

@sentry/browser bundle gzip'ed minified size: (ES5: 16.9316 kB) (ES6: 15.9688 kB)
📖 ✅ TSLint passed

Generated by 🚫 dangerJS against 0ffc01c

@kamilogorek kamilogorek mentioned this pull request Mar 24, 2020
Merged
@kamilogorek kamilogorek merged commit 1ed8a18 into master Mar 25, 2020
@kamilogorek kamilogorek deleted the ensure-promise-once branch March 25, 2020 13:16
This was referenced Mar 29, 2020
Merged
Merged
Merged
This was referenced Apr 17, 2020
Merged
Merged
Open
Closed
This was referenced Apr 27, 2020
Closed
Open
@snyk-bot snyk-bot mentioned this pull request May 5, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HazAT HazAT HazAT approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Promise in transport appears to invoke twice
3 participants
@kamilogorek @getsentry-bot @HazAT